CROSSLINK-232 modify action result#485
Merged
adamdickmeiss merged 11 commits intomainfrom Mar 26, 2026
Merged
Conversation
adamdickmeiss
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the patron-request “execute action” response to return a richer structured result (status + outcome + from/to state), wiring that data through the action service/event result and updating the OpenAPI contract and tests accordingly.
Changes:
- Expand action task
ResultDatato carryoutcomeandtoState, and populate them during action finalization. - Update
POST /patron-requests/{id}/actionto return the newActionResultshape (includingfromState/toState). - Adjust OpenAPI schema and update tests to unmarshal and assert the structured response.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| broker/test/patron_request/api/api-handler_test.go | Updates API tests to validate the expanded ActionResult JSON response. |
| broker/patron_request/service/action_test.go | Updates service tests to expect non-nil action result data. |
| broker/patron_request/service/action.go | Adds outcome/toState propagation and refactors outcome handling into EventResult. |
| broker/patron_request/api/api-handler.go | Returns expanded ActionResult fields (result/message/outcome/fromState/toState). |
| broker/oapi/open-api.yaml | Updates the ActionResult schema (renames field, adds required fields). |
| broker/events/eventmodels.go | Adds Outcome and ToState to shared event data/result payloads. |
jakub-id
requested changes
Mar 25, 2026
jakub-id
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://index-data.atlassian.net/browse/CROSSLINK-232